jQuery Grid Plugin - jqGrid

Hi,

There appears to be a problem with jqGrid’s date formatting when data is added using addRowData – dates are corrupted when they are formatted for display in the grid.

The problem can easily be seen by making a simple addition to the ok-soft-gmbh example found at TimeFormat.htm.  After the line of code containing the call to 'gridResize', add the following two lines:

            $grid.jqGrid('addRowData', 13, { id: "13″,  invdate: "2007-10-01T16:47″, invdate1: "2007-10-01T16:47″, name: "testXX",   note: "note",   amount: "200.00″, tax: "10.00″, closed: true,  ship_via: "TN", total: "210.00″ } );

            $grid.jqGrid('setGridParam',{ page: 1 }).trigger("reloadGrid");

Except for the ID and the name, the data being added here is identical to the 1^st row of data in myData.  However, when the grid is rendered after the ‘reloadGrid’ call, the date and time displayed in the grid for the data added using addRowData does not match the date and time of the 1^st row:

Date and time for 1^st row:                                                01.10.2007        16:47   

Date and time for row added with ‘addRowData’:               1.1.2001            0:10

(To make the comparison easier remove all but the 1^st row from myData in the original code; however, this is not necessary to reproduce the problem.)

I then modified the code to change all references from jqGrid “4.3.1” to “4.3.3” and found that the problem still exists in 4.3.3, but the date is corrupted to a different value:

Date and time for 1^st row:                                                01.10.2007        16:47   

Date and time for row added with ‘addRowData’:             30.03.2007        15:10

The problem appears to be due to the jqGrid code calling $.unformat.date that’s defined on or about line 5327 of the 4.3.3 version of jquery.jqGrid.src.js.  unformat.date is not called when the original data is loaded when the grid is created, only when data is added using addRowData.

A workaround fix that I’ve made to the $.unformat.date function in my local copy of  jquery.jqGrid.src.js is to add the code contained within the “apw change” comments below:

            $.unformat.date = function (cellval, opts) {

                        var op = $.jgrid.formatter.date || {};

                        if(!$.fmatter.isUndefined(opts.formatoptions)) {

                                    op = $.extend({},op,opts.formatoptions);

                        }                      

                        if(!$.fmatter.isEmpty(cellval)) {

                                    // start apw change

                                    if (Object.prototype.toString.call(cellval) === "[object Date]" ) {

                                                return cellval;

                                    }

                                    // end apw change

                                    return  $.fmatter.util.DateFormat(op.newformat,cellval,op.srcformat,op);

                        } else {

                                    return $.fn.fmatter.defaultFormat(cellval, opts);

                        }

            };

This change skips the unformat operation if the date to be formatted already is a Date object. In fact, this might be a useful change to include even when the underlying problem of parsing the in-bound date value is fixed, because there’s no need to perform this “unformat” operation if the object is already a date. 

For this change to work with the TimeFormat.htm example cited above, the two date strings in the data added by addRowData need to be changed to Date objects.