jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

id are saved with idPrefix in case of usage loadonce: true

Tags: idPrefix

26/03/2013
14:50

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hello Tony,

the line

ts.p._index[idr] = ts.p.data.length-1;

of addJSONData and another line with the same code later (see here) should be fixed to save in _index ids without id prefix like it will be done in case of datatype: "local". The fixed code can be for example

ts.p._index[$.jgrid.stripPref(ts.p.idPrefix,idr)] = ts.p.data.length-1;

The same changes one should make inside of addXmlData (in the line and in another one).

Best regards
Oleg

27/03/2013
09:58

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello Oleg

I think this should be additional checked, since I have made some changes in treeGrid regarding this before some days

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

27/03/2013
10:48

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hello Tony,

I have seen the changes in TreeGrid. In any way one have to use one way of saving ids in _index. The most methods (like addRowData and setRowData) use the fact that _index contains ids with stripped prefix (see here and this lines together with another one for example). So to be able to edit grid filled with loadonce: true option where idPrefix are used one have to fix the bug.

In any way one have to follow one way of saving ids in _index in all parts of jqGrid code.

Best regards
Oleg

27/03/2013
10:59

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Oleg,

I agree wit this and wil maybe revert the changes in treeGrid, so that they are compatible.

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

02/04/2013
13:36

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hallo Tony,

I want first remind you that the problem is not yet fixed in the code of jqGrid on github. Additionally I found that getLocalRow don't call $.jgrid.stripPref method. It seems wrong.

If would be good to search for all cases of usage ".p._index[" in the code of jqGrid and to follow one common way of usage rowid and indexes in _index. The most close to the current code is the way where data parameter are used directly to specify input data and some non-empty idPrefix are specified. In the case id without idPrefix are used as property of _index. In the same time all callbacks and all methods use rowid parameter with idPrefix. It seems for me the most native.

I think that one should fix all parts of jqGrid code to follow the way.

Best regards
Oleg

02/04/2013
14:42

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Oleg,

Thanks. Just working on this issue - it should be carfully fixed.

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
34 Guest(s)

Currently Browsing this Page:
1 Guest(s)