Forum

November 2nd, 2014
A A A
Avatar

Lost password?
Advanced Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 3 characters - maximum search word length is 84 characters

The forums are currently locked and only available for read only access
sp_Feed Topic RSS sp_Related Related Topics sp_TopicIcon
Duplicated rowid returned bug of select all header checkbox
24/12/2010
04:58
Avatar
jqgridnoob
Member
Members
Forum Posts: 3
Member Since:
24/12/2010
sp_UserOfflineSmall Offline

Hi everyone,

I am new to the fantasic jquery plugin and come up with some possibily bug.

My grid has the checkbox row for selecting rows including the header 'select all' box.

The bug happens when I checked some of the rows and then checked the header box.

If I use  $('#mgrpid').getGridParam('selarrrow'); to get the selected rows, the returned array contains duplicated rowids of all the rows I have selected before checking the header box.

I know I can manually clear the duplicated data but it seems not good for the performance.

And I tried to use the onSelectAll event to reset the selected rows but that donest seems to work too.

Is there any fix for this issue?

BTW the grid is generated by tabletoGrid if this matters.

25/12/2010
08:44
Avatar
silverhoof
New Member
Members
Forum Posts: 1
Member Since:
25/12/2010
sp_UserOfflineSmall Offline

We even found something worse, a critical bug.

The action flow is like this:

Assume we have 3 rows in a multi-select table

1. select one row, e.g. Row#2. Now row #2 is checked and in the selarrrow array.

2. select all row using the select all checkbox

3. Deselect the same row which we selected on step 1. Now row#2 is unchecked.

But we found that row#2 is still identified selected in selarrrow array which can't be corrected by our server side logic.

That is a critical bug and I wish you can fix this one ASAP. Thanks.

26/12/2010
13:52
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

Please look here:

http://www.trirand.com/blog/?p.....-1/#p21430

Kind Regards

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

27/12/2010
05:09
Avatar
jqgridnoob
Member
Members
Forum Posts: 3
Member Since:
24/12/2010
sp_UserOfflineSmall Offline

tony said:

Hello,

Please look here:

http://www.trirand.com/blog/?p.....-1/#p21430

Kind Regards


Hi Tony,

I can even reproducing the problem (including silverhoof's issue) on the demo page as u suggested.

On the custom mult-select page, if i first click ctrl + mouse on an item then press the select all check box, the alert shows duplicated item id. And if I deselect the previously checked item, it still recorded as checked.

I have tested the page on both IE8 and chrome and both can reproduce the bug.

       silverhoof's issue is really critical, please fix it ASAP.

27/12/2010
09:02
Avatar
jqgridnoob
Member
Members
Forum Posts: 3
Member Since:
24/12/2010
sp_UserOfflineSmall Offline

Read the source and found a quick fix.

Add the code of line

ts.p.selarrrow = [];

to clear the selarrrow on header checkbox click.

It should be line 1994 of grid.base.js

$('#cb_'+$.jgrid.jqID(ts.p.id),this).bind('click',function(){

ts.p.selarrrow = [];

if (this.checked) {

$("[id^=jqg_"+ts.p.id+"_"+"]").attr("checked","checked");

27/12/2010
09:19
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

Well that was. Thanks for the fix. Also fixed in GitHub

Best Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
35 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1255

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11373

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10592

Posts: 31289

Newest Members:

, razia, Prankie, psky, praveen neelam, greg.valainis@pa-tech.com

Moderators: tony: 7721, Rumen[Trirand]: 81

Administrators: admin: 66

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information