Forum

November 2nd, 2014
A A A
Avatar

Lost password?
Advanced Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 3 characters - maximum search word length is 84 characters

The forums are currently locked and only available for read only access
sp_Feed Topic RSS sp_Related Related Topics sp_TopicIcon
buildSelect bug in 4.5.2, with fix.
11/09/2013
23:09
Avatar
Grausam
Member
Members
Forum Posts: 10
Member Since:
27/02/2012
sp_UserOfflineSmall Offline

Only tested in editoptions. I'll play with sort options soon. 

There is a bug in the buildselect. My fixes are in red.

In 4.4.4

Line 5850:

var a, ovm = [], elem = this.elem, vl = this.vl, options = $.extend({},this.options), msl = options.multiple===true; if($.isFunction(options.buildSelect))

{

 var b = options.buildSelect.call($t,data);

 a = $(b).html();

}

else {

 a = $(data).html();

}

if(a) { $(elem).append(a);

....

elem is the <select tag>

In 4.5.2 at line 6055

var ovm = [], elem = this.elem, vl = this.vl, options = $.extend({},this.options), msl = options.multiple===true,

a = $.isFunction(options.buildSelect) ? options.buildSelect.call($t,data) : data;

if(typeof a === 'string') { a = $( $.trim( a ) ).html(); } //only happens if a is string

if(a) { $(elem).append(a);

Long Story Made Short: (My Fix)

a = $.isFunction(options.buildSelect) ? options.buildSelect.call($t, data) : data;

if (typeof a === 'string') { a = $.trim(a); }

a = $(a).html(); //This only gets applied if 'a' is a string in 4.5.2, according to 4.4.4 it has to be applied universally. 

if (a) {

 $(elem).append(a);

...

13/09/2013
11:42
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

Thanks for the investigation. I will check this next week.

Kind Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
9 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1255

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11373

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10592

Posts: 31289

Newest Members:

, razia, Prankie, psky, praveen neelam, greg.valainis@pa-tech.com

Moderators: tony: 7721, Rumen[Trirand]: 81

Administrators: admin: 66

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information