Forum

July 10th, 2011
You must be logged in to post Login Register

Search Forums:


 






some problems in grid.filter.js module

UserPost

22:13
15/01/2012


OlegK

Germany

Member

posts 1210

Hello Tony,

I found some problems in the filter module which I want describe here. The origin in the first problem is the missing of groupOps parameter in the call of jqFilter (see here) in the grid.formedit.js. One should add in the list of options the following

$("#"+fid).jqFilter({
    …
    groupOps: p.groupOps,
    …
});

The next probem are in the line 

inputAddSubgroup = $("<input type='button' value='+ {}' title='Add subgroup' class='add-group'/>");

this one

var inputAddRule = $("<input type='button' value='+' title='Add rule' class='add-rule ui-add'/>"), cm;

this line 

var inputDeleteGroup = $("<input type='button' value='-' title='Delete group' class='delete-group'/>");

and the line

var ruleDeleteInput = $("<input type='button' value='-' title='Delete rule' class='delete-rule ui-del'/>");

The first problem is that in all the above lines will be used non-locolized strings for the title attribute.

The next problem are the text in the buttons: '+ {}', '+' and '-'. I understand the advantage of the usage of language independent symbols which are short. The problem is that such symbols could be not intuitive enough. It can be hard depend on the level of the users which have to use the advance searching dialog.

My usggestion is to make all button textes and tolltips be configurable in i18ngrid.locale-xx.js file. So that one will be able to change the configuration to have the dialog like this one for example

After the first look on the dialog one can find natural to initialize jQuery UI Buttons with default settings on all the above buttons. One will receive the dialog like this

which corresponds more to the rest look of the dialog.

Best regards
Oleg 


About the jQuery Grid Plugin – jqGrid forum

Most Users Ever Online:

215


Currently Online:

70 Guests

Forum Stats:

Groups: 1

Forums: 7

Topics: 10279

Posts: 30383

Membership:

There are 11049 Members

There have been 448 Guests

There is 1 Admin

There are 2 Moderators

Top Posters:

OlegK – 1210

markw65 – 179

kobruleht – 144

phicarre – 132

YamilBracho – 124

Renso – 118

Administrators: admin (60 Posts)

Moderators: tony (7392 Posts), Rumen[Trirand] (81 Posts)




Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information