Forum

May 22nd, 2014
A A A

Please consider registering
guest

Log In Register

Register | Lost password?
Advanced Search

— Forum Scope —

  

— Match —

   

— Forum Options —

    

Minimum search word length is 4 characters - maximum search word length is 84 characters

Topic RSS Related Topics
some problems in grid.filter.js module
15/01/2012
22:13
OlegK
Germany
Member
Forum Posts: 1233
Member Since:
10/08/2009
Offline

Hello Tony,

I found some problems in the filter module which I want describe here. The origin in the first problem is the missing of groupOps parameter in the call of jqFilter (see here) in the grid.formedit.js. One should add in the list of options the following

$("#"+fid).jqFilter({
    ...
    groupOps: p.groupOps,
    ...
});

The next probem are in the line 

inputAddSubgroup = $("<input type='button' value='+ {}' title='Add subgroup' class='add-group'/>");

this one

var inputAddRule = $("<input type='button' value='+' title='Add rule' class='add-rule ui-add'/>"), cm;

this line 

var inputDeleteGroup = $("<input type='button' value='-' title='Delete group' class='delete-group'/>");

and the line

var ruleDeleteInput = $("<input type='button' value='-' title='Delete rule' class='delete-rule ui-del'/>");

The first problem is that in all the above lines will be used non-locolized strings for the title attribute.

The next problem are the text in the buttons: '+ {}', '+' and '-'. I understand the advantage of the usage of language independent symbols which are short. The problem is that such symbols could be not intuitive enough. It can be hard depend on the level of the users which have to use the advance searching dialog.

My usggestion is to make all button textes and tolltips be configurable in i18n\grid.locale-xx.js file. So that one will be able to change the configuration to have the dialog like this one for example

After the first look on the dialog one can find natural to initialize jQuery UI Buttons with default settings on all the above buttons. One will receive the dialog like this

which corresponds more to the rest look of the dialog.

Best regards
Oleg 

Forum Timezone: Europe/Sofia

Most Users Ever Online: 215

Currently Online: tony, wheeliea
89 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1233

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11313

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10522

Posts: 31092

Newest Members: wheeliea, dontbannedme, duyquang, jhardt1, HamidM, thaiphong.pham

Moderators: tony: 7665, Rumen[Trirand]: 81

Administrators: admin: 61

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information