jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

[Bug] definition of clearToolbar - v is not undefined, is not initialized.

Tags: clearToolbar search searchOptions defaultvalue

13/01/2012
17:03

Scevra

Member

Members

Forum Posts: 3

Member Since:
13/01/2012

Offline

Hi tony,

I saw the corrections you made, but I think I found another bug in the committed file js/grid.custom.js line 199-200:

https://github.com/tonytomov/jqGrid/commit/bd5ac35861c269ffa48f80dbdfd37d6d1be7dcb4#L0L199

Into the each part, in the last version (updated in GitHub) you have removed this line:


v = (this.searchoptions && this.searchoptions.defaultValue) ? this.searchoptions.defaultValue : "";

and you add only this line:


 if(this.searchoptions && this.searchoptions.defaultValue !== undefined) { v = this.searchoptions.defaultValue; }

But doing this, v is undefined the first time of the each (and all works well), but not in the future.
v can't be updated from the previous value if the IF condition fails (and that my case, in my application).
This is a problem, cause there are a lot of if ( v !== undefined ) in the code after that line.

So I think v has to be initialized every time after the $.each($t.p.colModel,function(i,n){.

I changed my code like this, and it works fine to me:

var clearToolbar = function(trigger){
               var sdata={}, v, j=0, nm;
               trigger = (typeof trigger != 'boolean') ? true : trigger;
               $.each($t.p.colModel,function(i,n){
                   v = undefined;
                    if(this.searchoptions && this.searchoptions.defaultValue !== undefined) { v = this.searchoptions.defaultValue; }
                   nm = this.index || this.name;
                   switch (this.stype) {

Is a bug, right?

Bye,
Scevra

14/01/2012
01:06

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

See here:

https://github.com/tonytomov/jqGrid/commit/36ae4008fbf4d4d47d7993c28d523c5f356e4f20

Thanks.

Kind Regards

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
67 Guest(s)

Currently Browsing this Page:
1 Guest(s)