jQuery Grid Plugin - jqGrid

Hello Tony,

during answering on the question on the stackoverflow I found a bug in jqGrid. I posted small pragmatical fix in the pull request. One can use the demo to reproduce the problem. Another demo uses the suggested fix and it works (sorting and searching) correctly. Below I post the analyse of the problem.

The problem exist is one uses

localReader: {repeatitems: true}

option. In the case the items of data will be saved in the form in which are included in the input. For example like

{ id: "50",  cell: ["test5",  "2007-10-31", "300.00", "20.00", "320.00", "false", "FE", "note5"] }

The problem is that all parts of local sorting and local filtering/searching works incorrectly in the case. The reason are the calls

query.orderBy(ts.p.sortname,...)

see the lines of addLocalData. It uses ts.p.sortname as the first parameter (by parameter) of orderBy, which will be forwarded to orderBy (see the line) and so on. As the result the line

ab=by!==""?$.jgrid.getAccessor(v,by):v;

will be used with the name instead of the index in colModel  (without taking in considerations cb, rn and subgrid columns). It's the reason why local sorting not works.

In the same way another line of addLocalData

query=compareFnMap[ts.p.postData.searchOper](query)(ts.p.postData.searchField,...);

uses ts.p.postData.searchField as the first parameter of compare functions. So the line

fld='jQuery.jgrid.getAccessor(this,\''+f+'\')';

will be used with f the as ts.p.postData.searchField which is the name of the corresponding field instead of the index. So searching will not work too.

Because of many possible other parts of the code I decided to suggest pragmatical and simple workaround: to modify the lines of code of addJSONData by adding the lines (see "else if" part)

if(locdata || ts.p.treeGrid===true){
    rd[locid]= $.jgrid.stripPref(ts.p.idPrefix, idr);
    ts.p.data.push(rd);
    ts.p._index[rd[locid]]= ts.p.data.length-1;
} else if(ts.p.datatype ==="local"&& dReader.repeatitems){
    var idStripted = $.jgrid.stripPref(ts.p.idPrefix, idr), iData = ts.p._index[idStripted];
    if(iData !==undefined&& ts.p.data !=null&& ts.p.data[iData]!=null){
        $.extend(true, ts.p.data[iData], rd);
    }
}

I think that close changes could be required in addXmlData (see here).