Forum

November 2nd, 2014
A A A
Avatar

Lost password?
Advanced Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 3 characters - maximum search word length is 84 characters

The forums are currently locked and only available for read only access
sp_Feed Topic RSS sp_TopicIcon
Upgrade from 4.5.0 to 4.5.2 breaks sorting Fixed Column grids????
27/05/2013
15:15
Avatar
mcslayton
Member
Members
Forum Posts: 9
Member Since:
12/09/2011
sp_UserOfflineSmall Offline

Absolutely NO code changes whatsoever -- just swapped in new jqGrid css and 4.5.2 js and now click on column headers -- no sorting. Swap 4.5.0 back in and sorting works fine.

27/05/2013
16:21
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

Sorry, but how you imagine to find the reason with such "bug report". Do you use local sorting or remote sorting (or use loadonce: true option)? Do you have problem with sorting in all columns of in some columns?

If you can't analyse to problem yourself, where is the test case (so other people could analyse the problem)? One can confirm the bug and fix it only if one can reproduce the problem.

28/05/2013
10:54
Avatar
zenixgrace
Jakarta
Member
Members
Forum Posts: 41
Member Since:
10/05/2010
sp_UserOfflineSmall Offline

Hi Oleg,

I try to make some example code.

Here is the link.

Hope this can help.

Warm Regards

28/05/2013
12:19
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

OK, an example clear what problem you have. I think that the reason of the problem is the following changes in jqGrid which seems me not correct. Tony should now more exactly the problem which he fixed with the fix and he could modify better the code so that the sorting of fixed columns stay and the original problem which should the changes fix do what needed.

Best regards
Oleg

P.S. Please use always jquery.jqGrid.src.js instead of jquery.jqGrid.min.js in demos which reproduces bugs. You should include test data in the grid too (it's better to use datatype: "local" if possible to reproduce bugs).

28/05/2013
18:16
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

Many thanks. Fixed in GitHub

Regards

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

28/05/2013
18:21
Avatar
mcslayton
Member
Members
Forum Posts: 9
Member Since:
12/09/2011
sp_UserOfflineSmall Offline

OlegK said:

Sorry, but how you imagine to find the reason with such "bug report". Do you use local sorting or remote sorting (or use loadonce: true option)? Do you have problem with sorting in all columns of in some columns?

If you can't analyse to problem yourself, where is the test case (so other people could analyse the problem)? One can confirm the bug and fix it only if one can reproduce the problem.


Test Case: http://app.thecybersafe.net/jq.....dTest.aspx

Sorry, since the bugs are so obvious I thought it wouldn't need a test case. There are two issues:

1) the frozen columns feature doesn't work until you page the grid OR select an entry from the rowList dropdown.

2) clicking on the column headers for sorting does nothing. Icon remains the same and the rows do not re-sort.

28/05/2013
20:34
Avatar
mcslayton
Member
Members
Forum Posts: 9
Member Since:
12/09/2011
sp_UserOfflineSmall Offline

tony said:

Hello,

Many thanks. Fixed in GitHub

Regards


Hi Tony,

Thanks for the quick fix. It does fix the sorting issues when frozen columns are used, BUT, the issue with the rows sliding under the frozen columns is still there.

The test case is:  Test Case Link

When you first hit page just move horizontal slider — row detail slides under column headings. Once you sort or page then all is okay.

Thanks, Marv

28/05/2013
21:45
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

Hi Marv,

I think it's the old problem described here and here. As the workaround you can include

$('#tabGrid').triggerHandler('jqGridAfterGridComplete');

after

$('#tabGrid').jqGrid('setFrozenColumns');

In my opinion the method setFrozenColumns should execute the event handler once directly after the binding.

Best regards
Oleg 

28/05/2013
23:21
Avatar
mcslayton
Member
Members
Forum Posts: 9
Member Since:
12/09/2011
sp_UserOfflineSmall Offline

OlegK said:

Hi Marv,

I think it's the old problem described here and here. As the workaround you can include

$('#tabGrid').triggerHandler('jqGridAfterGridComplete');

after

$('#tabGrid').jqGrid('setFrozenColumns');

In my opinion the method setFrozenColumns should execute the event handler once directly after the binding.

Best regards
Oleg 

Thanks Oleg. That worked, so jqGrid 4.5.2 version with patch noted above is now working great!


29/05/2013
16:55
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

In which brower is this. I can  not see the problem when I exludethe line

$('#tabGrid').triggerHandler('jqGridAfterGridComplete');

from your code.

Regards

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

29/05/2013
18:04
Avatar
mcslayton
Member
Members
Forum Posts: 9
Member Since:
12/09/2011
sp_UserOfflineSmall Offline

tony said:

Hello,

In which brower is this. I can  not see the problem when I exludethe line

$('#tabGrid').triggerHandler('jqGridAfterGridComplete');

from your code.

Regards


Hi Tony,

I have commented out the line on the test page and so that latest versions of Google Chrome (v27.0.1453.94 m), Firefox (v22.0) and IE (v10.0.9200.16580) all have the same problem:

Hit the test page above and immedialtely move the row slider to the right -- the row detail slide under the column headers.

Let me know if you need some thing else.

Thanks, Marv

29/05/2013
18:16
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

Tony,

the problem exist in all web browsers I think, for example IE10, Google Chrome 27.0.1453.94 and Firefox 21.

I reported the bug multipte times (the first time was here I think), but you removed execution of jqGridAfterGridComplete handler (or _complete). Probebly it's time to fix the problem.

To reproduce the bug one can use the demo. In the demo only the column headers are frozen. Another demo uses just triggerHandler("jqGridAfterGridComplete") directly after setFrozenColumns. I think that if one uses setFrozenColumns on the grid with filled data then if works incorrectly. One should execute the handler always at the end of setFrozenColumns.

Best regards
Oleg 

30/05/2013
05:12
Avatar
zenixgrace
Jakarta
Member
Members
Forum Posts: 41
Member Since:
10/05/2010
sp_UserOfflineSmall Offline

OlegK said:

P.S. Please use always jquery.jqGrid.src.js instead of jquery.jqGrid.min.js in demos which reproduces bugs. You should include test data in the grid too (it's better to use datatype: "local" if possible to reproduce bugs).


Hi Oleg,

OK. noted sir Laugh

Warm Regards,

14/06/2013
16:25
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

Many thanks. Just fixed the problem in GitHub.

Please let me know if this fix works.

Regards

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

14/06/2013
17:11
Avatar
mcslayton
Member
Members
Forum Posts: 9
Member Since:
12/09/2011
sp_UserOfflineSmall Offline

tony said:

Hello,

Many thanks. Just fixed the problem in GitHub.

Please let me know if this fix works.

Regards


Hi Tony,

The fix works great! Thanks.

Regards, Marv

16/06/2013
19:08
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

Hello Tony,

in general I agree with the changes, but I personally would implement the changes in a little another way. I would just call the event handler directly instead of triggering jqGridAfterGridComplete event which could be used by other.

What I mean is the following. The old code (see here) looks about as following

$($t).bind('jqGridAfterGridComplete.setFrozenColumns', function () {
    // create "#"+$.jgrid.jqID($t.p.id)+"_frozen"
    //   from "#"+$.jgrid.jqID($t.p.id)
    // append it to fbDiv and set hover handler
    ...
});
$t.p.frozenColumns = true; 

I would change the code to

var fillFrozenBodyDiv = function () {
    // create "#"+$.jgrid.jqID($t.p.id)+"_frozen"
    //   from "#"+$.jgrid.jqID($t.p.id)
    // append it to fbDiv and set hover handler
    ...
};
$($t).bind('jqGridAfterGridComplete.setFrozenColumns', fillFrozenBodyDiv);
if(!$t.grid.hDiv.loading) {
    fillFrozenBodyDiv();
}
$t.p.frozenColumns = true; 

The usage of

$($t).triggerHandler("jqGridAfterGridComplete");

instead of 

fillFrozenBodyDiv();

is not only a little slowly, but it simulate grid complete event at the moment when real grid complete is not done. It follows to unneeded execution of all event handlers of jqGridAfterGridComplete event, which would be not full correct.

In the answer I described that gridComplete callback and jqGridAfterGridComplete event are exectued already in jqGrid much more frequntly as needed. So I recommended to prefere loadComplete and jqGridLoadComplete or jqGridAfterLoadComplete instead of gridComplete callback and jqGridAfterGridComplete event. The last modification of setFrozenColumns would add one more point of unneeded execution of jqGridAfterGridComplete.

Best regards
Oleg 

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
59 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1255

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11373

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10592

Posts: 31289

Newest Members:

, razia, Prankie, psky, praveen neelam, greg.valainis@pa-tech.com

Moderators: tony: 7721, Rumen[Trirand]: 81

Administrators: admin: 66

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information