jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

typing bug with max/min in addJSONData and addXmlData

Tags: addJSONData addXmlData

19/12/2011
19:47

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hello Tony,

in addJSONData and addXmlData there are typing bug (the lines 1212 and 1383):

ts.p.lastpage = Math.min( ts.p.page, Math.ceil(gl/ rn) );

ts.p.lastpage = Math.min( ts.p.page, Math.ceil(len/ rn) );

should be fixed to

ts.p.lastpage = Math.max( ts.p.page, Math.ceil(gl/ rn) );

ts.p.lastpage = Math.max( ts.p.page, Math.ceil(len/ rn) );

Probobly even better to go back to the original lines

ts.p.lastpage = Math.ceil(gl/rn);

and

ts.p.lastpage = Math.ceil(len/rn);

To reproduce the bug one can just fill the grid having loadonce: true option with many pages of data. If the page parameter of the JSON data are set for example to 1 (the first page schould be displayed), then the lastpage will be set to 1, corresponds to the above described bug, instead of Math.ceil(len/rn) which correspond to the number of read records.

It's bug from my old suggestion. After the line 1117 with

if (gl > 0 && ts.p.page <= 0) { ts.p.page = 1; }

and the line 1286 with

if (len > 0 && ts.p.page <= 0) { ts.p.page = 1; }

were included in the jqGrid code the real problem which should fix ts.p.lastpage = Math.max( ts.p.page, Math.ceil(gl/ rn) ); will be eliminiet. Sorry.

Best regards
Oleg

20/12/2011
12:25

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello Oleg,

No need to say Sorry. I must say Thank you.

Just released the 4.3.1

Best Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

20/12/2011
13:07

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Congratulation!

It's good to publish releases with bug fixes.

Best regards
Oleg

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
40 Guest(s)

Currently Browsing this Page:
1 Guest(s)