Forum

May 22nd, 2014
A A A

Please consider registering
guest

Log In Register

Register | Lost password?
Advanced Search

— Forum Scope —

  

— Match —

   

— Forum Options —

    

Minimum search word length is 4 characters - maximum search word length is 84 characters

Topic RSS
small bug with reading id=0
25/03/2013
13:03
OlegK
Germany
Member
Forum Posts: 1231
Member Since:
10/08/2009
Offline

Hallo Tony,

during answering on one question I found the bug in the line of code

idr = ccur !== undefined ? ccur[idn] || idr : idr;

(and this one too

idr = ccur2[idn] || idr;

later in the code). The problem one have if ccur[idn] (or ccur2[idn]) is 0 (the id of the row is numeric 0). In the case it will be used idr instead of ccur[idn] (or ccur2[idn]) which can follow to id dupplicates.

To fix the problem one should test for ccur[idn] !== undefined instead of usage || operation. Additionally one can change the first test ccur !== undefined to ccur != null, to be sure that ccur is neither undefined nor null before usage of ccur[idn].

By the way to reproduce the proglem one can add key: true to some colum and use standard format where cell array is defined in JSON input data. For example

{"rows":[{"cell":[0,...]}, {"cell":[1,...]}, ...]}

In the case idn will be set to 0 (index of the first column which has key:true property). The line

idr = $.jgrid.getAccessor(cur,idn);

will returns always undefined value and we will fall down in the case which I descrined above.

Best regards
Oleg 

27/03/2013
09:49
tony
Sofia, Bulgaria
Moderator
Forum Posts: 7620
Member Since:
30/10/2007
Offline

Hello Oleg,

Thanks.

Tony

For professional UI suites for PHP, ASP.NET and ASP.NET MVC visit us at our commercial products site - trirand.net - by the very same guys that created jqGrid.
Forum Timezone: Europe/Sofia

Most Users Ever Online: 215

Currently Online: Nahro
85 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1231

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11284

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10486

Posts: 31001

Newest Members: jimssell, zizzzac, Nahro, kefeoglu, davsha77, Elizabeth_Keen

Moderators: tony: 7620, Rumen[Trirand]: 81

Administrators: admin: 61

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information