Forum

July 10th, 2011
You must be logged in to post Login Register

Search Forums:


 






small bug with reading id=0

No Tags
UserPost

13:03
25/03/2013


OlegK

Germany

Member

posts 1210

Hallo Tony,

during answering on one question I found the bug in the line of code

idr = ccur !== undefined ? ccur[idn] || idr : idr;

(and this one too

idr = ccur2[idn] || idr;

later in the code). The problem one have if ccur[idn] (or ccur2[idn]) is 0 (the id of the row is numeric 0). In the case it will be used idr instead of ccur[idn] (or ccur2[idn]) which can follow to id dupplicates.

To fix the problem one should test for ccur[idn] !== undefined instead of usage || operation. Additionally one can change the first test ccur !== undefined to ccur != null, to be sure that ccur is neither undefined nor null before usage of ccur[idn].

By the way to reproduce the proglem one can add key: true to some colum and use standard format where cell array is defined in JSON input data. For example

{"rows":[{"cell":[0,...]}, {"cell":[1,...]}, …]}

In the case idn will be set to 0 (index of the first column which has key:true property). The line

idr = $.jgrid.getAccessor(cur,idn);

will returns always undefined value and we will fall down in the case which I descrined above.

Best regards
Oleg 


09:49
27/03/2013


tony

Sofia, Bulgaria

Moderator

posts 7371

Hello Oleg,

Thanks.


Tony

For professional UI suites for PHP, ASP.NET and ASP.NET MVC visit us at our commercial products site – trirand.net – by the very same guys that created jqGrid.

No Tags

About the jQuery Grid Plugin – jqGrid forum

Most Users Ever Online:

215


Currently Online:

72 Guests

Forum Stats:

Groups: 1

Forums: 7

Topics: 10267

Posts: 30340

Membership:

There are 11029 Members

There have been 448 Guests

There is 1 Admin

There are 2 Moderators

Top Posters:

OlegK – 1210

markw65 – 179

kobruleht – 144

phicarre – 132

YamilBracho – 124

Renso – 118

Administrators: admin (60 Posts)

Moderators: tony (7371 Posts), Rumen[Trirand] (81 Posts)




Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information