Forum
Log In
Home
Topic RSS
14:00
23/07/2008
Offline
Hi tony,
I just searched for hours before I foudn this really nasty bug (well, in fact there are two).
Fist bug: I added additional css classes to my pager element for styling. Unfortunately, your code in the base js file (line 1013) checks if the class "scroll" is set, but exclusevely. So, if I add additional classes your if won't work!!!
Pelase change this asap so that the if checks if the class is present but pelase not exclusively.
second bug (and this is the really nasty one): When searching for the first bug I noticed that a second grid (almost same parameters) wored fine with its pager, the only big difference was that hiddengrid was set to true. So, I looked a long time before I saw the conclusion: when showing the contents of a hiddengrid, you leave the check of bug 1 aside, you just show the pager regardless if the class "scroll" is given or not (ignoring the user setttings). So, if it would have worked correctly, this pager wouldn't have worked as well because of bug 1, but since you don't do the same in both cases it works with a hiddengrid.
So please, please: get rid of bug1 and take care that in case of a hiddengrid everything is done accordingly to the normal behaviour (only "later").
I will cahnge this in my code in the meantime but I hope that a bigfix release will come out soon. Until then, you should add to the documentation that the class "scrolL" has to be given exclusively to the pager.
BR,
Creativebyte
14:30
23/07/2008
Offline
Additonal notice:
Why do I need to give the pager the class "scroll" anyway? Can't you do it while setting up the pager? Would save a few bits and would help gettign around this check completely...
For solving bug1 I already did it in my code. Just exchange your if() with:
if( $(ts.p.pager).attr("class").search(/scroll/) != -1)
and it works. But for rewriting the hiddengrid method: I have no idea how to do it quickly and I am prettyl ucky that I need the pager there...
02:16
Moderators
30/10/2007
Offline
Thanks for this it will be corrected.
I think that a better way to check this is hasClass
The reason to set manual class of pager is that they can be put
where you want.
Thank you
Regards
Tony
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
02:39
23/07/2008
Offline
Hi tony,
I don't get this reason. Of course I can put the pager html element where I want. But since you have the jQuery selector of the pager, this doesn't matter, does it?
So, in my opinion it's like this: when a pager selector is given you set the class scroll automatically. You could even bind this on viewrecords:true if you like.
BR,
Creativebyte
04:27
Moderators
30/10/2007
Offline
Hi,
I do not agree with this - if you set the pager where you want -
how will jqGrid known where to add buttons and etc 
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
05:01
23/07/2008
Offline
Sorry, I still don't get it. The only thing that jqgrid knows about the pager is just the jquery selector from the options array. By using this, you do everything, starting from showing the whole thing to adding buttons and navigation images to it. So, Why does it matter where the pager is?
Anyway: if you don't want to set the scroll class automatically it's ok.
Most Users Ever Online: 715
Currently Online:
60 Guest(s)
Currently Browsing this Page:
1 Guest(s)
Top Posters:
OlegK: 1255
markw65: 179
kobruleht: 144
phicarre: 132
YamilBracho: 124
Renso: 118
Member Stats:
Guest Posters: 447
Members: 11373
Moderators: 2
Admins: 1
Forum Stats:
Groups: 1
Forums: 8
Topics: 10592
Posts: 31289
Newest Members:
, razia, Prankie, psky, praveen neelam, greg.valainis@pa-tech.comModerators: tony: 7721, Rumen[Trirand]: 81
Administrators: admin: 66
