jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

one need use deep (recursive) jQuery.extend in grid.formedit.js

Tags: $.jgrid.edit options

21/11/2012
13:41

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hallo Tony,

during answering of one question on the stackoverflow I found bugs in grid.formedit.js module. The method editGridRow for example use in the lines the call of jQuery.extend without the usage of deep (recursive) version. So the current code uses

p = $.extend({...}, $.jgrid.edit, p || {});

So all options which are objects (ajaxEditOptions, editData, savekey, navkeys, ...) can be extended incorrectly especially if some settings of the options are set in both $.jgrid.edit and input parameters of editGridRow. In the case the options will be not combined as expected. To fix the problem one can use

p = $.extend(true, {...}, $.jgrid.edit, p || {});

It seems to me that one should use deep form of jQuery.extend everywhere in the code of jqGrid.

Best regards
Oleg

22/11/2012
12:10

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Thanks Oleg,

I have made a pull request.

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
44 Guest(s)

Currently Browsing this Page:
1 Guest(s)