Forum

November 2nd, 2014
A A A
Avatar

Please consider registering
guest

sp_LogInOut Log In

Lost password?
Advanced Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 4 characters - maximum search word length is 84 characters

The forums are currently locked and only available for read only access
sp_Feed Topic RSS sp_TopicIcon
Html td bug
10/09/2012
11:56
Avatar
para
Member
Forum Posts: 3
Member Since:
10/09/2012
sp_UserOfflineSmall Offline

Hi,

I found a bug in jqgrid and also fixed it on my local machine.

I want to know how I can submit my solution to the common repository

The problem involves editing html data in the grid(in a textarea for example) and this html data should contain <td> elements.

The problem is with this selector

td:eq("+i+")

that selects and td elements that are descendents of the tr element with the class ui-widget-content

To get it to select the proper elements I changed this to:

$("td[role='gridcell']:eq("+i+")",obj.rows[ind])

So. Should this be included in the official build?

If so how do I do that?\

Thank you for your time.

10/09/2012
18:46
Avatar
tony
Sofia, Bulgaria
Moderator
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

You can use a GitHub here:

Thank you.

Regards

For professional UI suites for PHP, ASP.NET and ASP.NET MVC visit us at our commercial products site - trirand.net - by the very same guys that created jqGrid.
12/09/2012
14:40
Avatar
para
Member
Forum Posts: 3
Member Since:
10/09/2012
sp_UserOfflineSmall Offline

Hi, I made my modifications in this file jquery.jqGrid.src.js

which file should I modify on github?

I don't see a similar file

Thank you.

Sorry for the stupid question but I am new to this.

14/09/2012
15:23
Avatar
tony
Sofia, Bulgaria
Moderator
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

You shold have registration in Git Hub. See the GitHubs Documentation.

If you do not want to do this please use the jquery.jqGrid.src.js

and publish the modifcatins here like this by example

line  123 is: 

a=1;

should be: 

a=2;

Hope you got the point.

Regards

Tony

For professional UI suites for PHP, ASP.NET and ASP.NET MVC visit us at our commercial products site - trirand.net - by the very same guys that created jqGrid.
17/09/2012
14:21
Avatar
para
Member
Forum Posts: 3
Member Since:
10/09/2012
sp_UserOfflineSmall Offline

Hi,

I managed to figure out the right file to make the changes to was grid.base.js. I tried uploading the modifications.

I have a github account but I get this error when I try to push the changes

Pushing to https://github.com/tonytomov/jqGrid.git
error: The requested URL returned error: 403 while accessing https://github.com/tonytomov/jqGrid.git/info/refs
fatal: HTTP request failed

I am guessing this is because the git repository is read-only. I am using this one https://github.com/tonytomov/jqGrid.git

I don't see any non-read-only repositories to push the changes too.

Anyway here are the changes I made to jquery.jqGrid.src.js:

line  2870 is: 

$("td:eq("+i+") > span:first",ind).html(vl).attr(title);

should be: 

$("td[role='gridcell']:eq("+i+") > span:first",ind).html(vl).attr(title);

----------------------

line  2872 is: 

$("td:eq("+i+")",ind).html(vl).attr(title);

should be: 

$("td[role='gridcell']:eq(" + i + ")", ind).html(vl).attr(title);

----------------------

line  7313 is: 

tmp = $("td:eq("+i+")",obj.rows[ind]).text();

should be: 

tmp = $("td[role='gridcell']:eq("+i+")",obj.rows[ind]).text();

----------------------

line  7316 is: 

tmp =  $.unformat.call(obj, $("td:eq("+i+")",obj.rows[ind]),{rowId:rowid, colModel:this},i);

should be: 

tmp =  $.unformat.call(obj, $("td[role='gridcell']:eq("+i+")",obj.rows[ind]),{rowId:rowid, colModel:this},i);

----------------------

line  7318 is: 

tmp =  (this.edittype && this.edittype == "textarea") ? $("td:eq("+i+")",obj.rows[ind]).text() : $("td:eq("+i+")",obj.rows[ind]).html();

should be: 

tmp =  (this.edittype && this.edittype == "textarea") ? $("td[role='gridcell']:eq("+i+")",obj.rows[ind]).text() : $("td[role='gridcell']:eq("+i+")",obj.rows[ind]).html();

----------------------

line  8138 is: 

tmp = $("td:eq("+i+")",obj.rows[ind]).text();

should be: 

tmp = $("td[role='gridcell']:eq("+i+")",obj.rows[ind]).text();

----------------------

line  8140 is:

tmp = $("td:eq("+i+")",obj.rows[ind]).html();

should be: 

tmp = $("td[role='gridcell']:eq("+i+")",obj.rows[ind]).html();

27/09/2012
13:21
Avatar
tony
Sofia, Bulgaria
Moderator
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

Thanks. The fix is in GitHub.

Best Regards

For professional UI suites for PHP, ASP.NET and ASP.NET MVC visit us at our commercial products site - trirand.net - by the very same guys that created jqGrid.
Forum Timezone: Europe/Sofia

Most Users Ever Online: 215

Currently Online:
66 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1255

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11373

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10592

Posts: 31289

Newest Members:

razia, Prankie, psky, praveen neelam, greg.valainis@pa-tech.com, swathi

Moderators: tony: 7721, Rumen[Trirand]: 81

Administrators: admin: 66

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information