Forum

May 22nd, 2014
A A A

Please consider registering
guest

Log In Register

Register | Lost password?
Advanced Search

— Forum Scope —

  

— Match —

   

— Forum Options —

    

Wildcard usage:
*  matches any number of characters    %  matches exactly one character

Minimum search word length is 4 characters - maximum search word length is 84 characters

Topic RSS
DataUrl: ajax should use "success", not "complete"
15/06/2010
02:24
vchekan
Member
Forum Posts: 10
Member Since:
07/06/2010
Offline

http://github.com/tonytomov/jq…..on.js#L321

if(typeof(options.dataUrl) != "undefined") {

  complete: function(data,status){

if(typeof(options.buildSelect) != "undefined") {
var b = options.buildSelect(data);

I have strong impression that "complete" property was used by mistake.

First, of all, you perhaps do not want to feed error-ended call into buildSelect()

Second, "data" is XMLHttpRequest in fact. If you change "complete" to "success", then 1st argument will be "data" as intended.

16/06/2010
13:08
tony
Sofia, Bulgaria
Moderator
Forum Posts: 7514
Member Since:
30/10/2007
Offline

Hello,

Maybe you are right, but changing right now complete with succes will cause all existing users to change a lot of code and expect a lot of problems.

Best Regards

Tony

For professional UI suites for PHP, ASP.NET and ASP.NET MVC visit us at our commercial products site - trirand.net - by the very same guys that created jqGrid.
17/06/2010
20:26
vchekan
Member
Forum Posts: 10
Member Since:
07/06/2010
Offline

Well, I don't know. My guess is that most of existing code is broken, because I doubt people check that completion status is 'success'.

So may be it is possible to add a backward compatibility bit and retire old behaviour in a grace fashion?

Another option would be to introdcue another callback, let's say "dataUrlReady" which would be called properly. With clear documentation it would allow new code to do right things without breaking backward compatibility.

Forum Timezone: Europe/Sofia

Most Users Ever Online: 215

Currently Online: tomyee3, hemadri
64 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1214

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11192

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10394

Posts: 30715

Newest Members: sunilkatta99, Surendra Rayapati, rize, Jamil1234, poff, hemadri

Moderators: tony (7514), Rumen[Trirand] (81)

Administrators: admin (61)

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information