Forum

July 10th, 2011
You must be logged in to post Login Register

Search Forums:


 






DataUrl: ajax should use "success", not "complete"

No Tags
UserPost

02:24
15/06/2010


vchekan

Member

posts 10

http://github.com/tonytomov/jq…..on.js#L321

if(typeof(options.dataUrl) != "undefined") {

  complete: function(data,status){

if(typeof(options.buildSelect) != "undefined") {
var b = options.buildSelect(data);

I have strong impression that "complete" property was used by mistake.

First, of all, you perhaps do not want to feed error-ended call into buildSelect()

Second, "data" is XMLHttpRequest in fact. If you change "complete" to "success", then 1st argument will be "data" as intended.

13:08
16/06/2010


tony

Sofia, Bulgaria

Moderator

posts 7375

Hello,

Maybe you are right, but changing right now complete with succes will cause all existing users to change a lot of code and expect a lot of problems.


Best Regards

Tony

For professional UI suites for PHP, ASP.NET and ASP.NET MVC visit us at our commercial products site – trirand.net – by the very same guys that created jqGrid.

20:26
17/06/2010


vchekan

Member

posts 10

Well, I don't know. My guess is that most of existing code is broken, because I doubt people check that completion status is 'success'.

So may be it is possible to add a backward compatibility bit and retire old behaviour in a grace fashion?


Another option would be to introdcue another callback, let's say "dataUrlReady" which would be called properly. With clear documentation it would allow new code to do right things without breaking backward compatibility.

No Tags

About the jQuery Grid Plugin – jqGrid forum

Most Users Ever Online:

215


Currently Online:

33 Guests

Forum Stats:

Groups: 1

Forums: 7

Topics: 10271

Posts: 30349

Membership:

There are 11036 Members

There have been 448 Guests

There is 1 Admin

There are 2 Moderators

Top Posters:

OlegK – 1210

markw65 – 179

kobruleht – 144

phicarre – 132

YamilBracho – 124

Renso – 118

Administrators: admin (60 Posts)

Moderators: tony (7375 Posts), Rumen[Trirand] (81 Posts)




Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information