Forum

November 2nd, 2014
A A A
Avatar

Lost password?
Advanced Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 3 characters - maximum search word length is 84 characters

The forums are currently locked and only available for read only access
This topic is locked No permission to create posts
sp_Feed Topic RSS sp_TopicIcon
Bug in the single search dialog box
18/04/2011
18:51
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

Hi Tony,

The single search dialog box now has an extra dropdown list on top that was not there in the previous version (see image link).

Is there anyway to set it to automatically disappear when the grid is set to do single search?

single searchImage Enlarger

[Image Can Not Be Found]

Thanks for your help Tony!

Jack

18/04/2011
20:42
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

18/04/2011
22:21
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

tony said:

Hello,

Thanks. Just fixed.

https://github.com/tonytomov/jqGrid/commit/8e4803ea3764175c208443e492801a30f38218e9

Best Regards

Tony


Thanks a lot for the quick response Tony!

The Grouping dropdown is now gone when the dialog opens. But when the Refresh button is pressed, it returns again with a + button to the right of it (see image link). Perhaps the entire parent tr element need to be removed?

single search 2Image Enlarger

Thanks again Tony!

Jack

18/04/2011
22:21
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

tony said:

Hello,

Thanks. Just fixed.

https://github.com/tonytomov/jqGrid/commit/8e4803ea3764175c208443e492801a30f38218e9

Best Regards

Tony


Thanks a lot for the quick response Tony!

The Grouping dropdown is now gone when the dialog opens. But when the Refresh button is pressed, it returns again with a + button to the right of it (see image link). Perhaps the entire parent tr element need to be removed?

single search 2Image Enlarger

Thanks again Tony!

Jack

19/04/2011
09:50
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

Thanks.

I hope this time everthing is ok with the fix:

https://github.com/tonytomov/jqGrid/commit/abd9bd3067311783f942263133ee667369562ab9

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

19/04/2011
13:13
Avatar
korys
New Member
Members
Forum Posts: 1
Member Since:
19/04/2011
sp_UserOfflineSmall Offline

Hello,

I'll just stick to this topic. I noticed that defining multisearch options: 'groupOps', 'matchText', 'rulesText' – using navGrid method, does nothing. I can't change english 'AND' and 'OR' in select or add texts.  Didn't try other methods.

I tried to manually update jquery.jqGrid.src file with above fix, and when I set grid to single searching I get JS error 'hideButtons is not defined'.

Second thing:

I dynamically set searchoptions sopt for each column after loadComplete with setColProp method. It sets options fine, but if don't change search operator in 'selectopts' select in search window, in request it sets

"op":"eq"

by default, even though I don't have it in select options.

Thanks for help.

Sry for my English

19/04/2011
15:15
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

korys said:

Hello,

I'll just stick to this topic. I noticed that defining multisearch options: 'groupOps', 'matchText', 'rulesText' - using navGrid method, does nothing. I can't change english 'AND' and 'OR' in select or add texts.  Didn't try other methods.

I tried to manually update jquery.jqGrid.src file with above fix, and when I set grid to single searching I get JS error 'hideButtons is not defined'.


Thanks for the quick response Tony.

Like korys, I'm also experiencing the multisearch functionality no longer functioning after the fix (i.e. the + and - buttons and the AND OR select list not showing up). I'm using the following code to enable multisearch.

searchGrid.jqGrid('navGrid', '#searchGridPager', { add: false, edit: false, del: false }, {}, {}, {}, { multipleSearch: true });

Jack

19/04/2011
15:39
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

@korys

I'll just stick to this topic. I noticed that defining multisearch options: 'groupOps', 'matchText', 'rulesText' – using navGrid method, does nothing. I can't change english 'AND' and 'OR' in select or add texts.  Didn't try other methods.

As you can imagine these texts are not valid since there are no such select boxes. These will be added later.

I tried to manually update jquery.jqGrid.src file with above fix, and when I set grid to single searching I get JS error 'hideButtons is not defined'.

This is very bad idea. Did you think that this is the only change that impact the problem. Did you see the other changes related to these problems.

I dynamically set searchoptions sopt for each column after loadComplete with setColProp method. It sets options fine, but if don't change search operator in 'selectopts' select in search window, in request it sets

This problem is fixed too. Please look all the changes in the GitHub.

In the future please download the copy from GitHub and use this copy.

@jhsu,

Evrething work wor me OK. Did you download the copy from GitHub or you just make a manual changes like @korys.?

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

19/04/2011
16:20
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

tony said:

Hello,

@korys

I'll just stick to this topic. I noticed that defining multisearch options: 'groupOps', 'matchText', 'rulesText' – using navGrid method, does nothing. I can't change english 'AND' and 'OR' in select or add texts.  Didn't try other methods.

As you can imagine these texts are not valid since there are no such select boxes. These will be added later.

I tried to manually update jquery.jqGrid.src file with above fix, and when I set grid to single searching I get JS error 'hideButtons is not defined'.

This is very bad idea. Did you think that this is the only change that impact the problem. Did you see the other changes related to these problems.

I dynamically set searchoptions sopt for each column after loadComplete with setColProp method. It sets options fine, but if don't change search operator in 'selectopts' select in search window, in request it sets

This problem is fixed too. Please look all the changes in the GitHub.

In the future please download the copy from GitHub and use this copy.

@jhsu,

Evrething work wor me OK. Did you download the copy from GitHub or you just make a manual changes like @korys.?

Regards

Tony


I just got multisearch working by using the default search button in the navGrid bar, but if I use my own custom search button as follows, then the multisearch elements don't show up in the dialog.

searchGrid.jqGrid('navGrid', '#searchGridPager', { add: false, edit: false, del: false}, {}, {}, {}, { multipleSearch: true });
searchGrid.jqGrid('navButtonAdd', '#searchGridPager', { caption: 'Search', buttonicon: 'custom-search',
 onClickButton: function () {
  $(this).jqGrid('searchGrid');
 }
}); 

I downloaded the latest code from grid.filter.js and grid.formedit.js that were changed most recently and ensured that i have the latest in other files as well.

 

Jack

19/04/2011
17:28
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Hello,

 just got multisearch working by using the default search button in the navGrid bar, but if I use my own custom search button as follows, then the multisearch elements don't show up in the dialog.

searchGrid.jqGrid('navButtonAdd', '#searchGridPager', { caption: 'Search', buttonicon: 'custom-search',
 onClickButton: function () {
  $(this).jqGrid('searchGrid');
 }
});

How do you expect this to happen if you do not set multipleSearch parameter?

You set it in the snadard navigator, but not in the custom button

Just for the record try this and let us know if it work.

searchGrid.jqGrid('navButtonAdd', '#searchGridPager', { caption: 'Search', buttonicon: 'custom-search',
 onClickButton: function () {
  $(this).jqGrid('searchGrid',{'multipleSearch':true} );
 }
});

 Enjoy

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

19/04/2011
17:42
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

tony said:

Hello,

 just got multisearch working by using the default search button in the navGrid bar, but if I use my own custom search button as follows, then the multisearch elements don't show up in the dialog.

searchGrid.jqGrid('navButtonAdd', '#searchGridPager', { caption: 'Search', buttonicon: 'custom-search',
 onClickButton: function () {
  $(this).jqGrid('searchGrid');
 }
});

How do you expect this to happen if you do not set multipleSearch parameter?

You set it in the snadard navigator, but not in the custom button

Just for the record try this and let us know if it work.

searchGrid.jqGrid('navButtonAdd', '#searchGridPager', { caption: 'Search', buttonicon: 'custom-search',
 onClickButton: function () {
  $(this).jqGrid('searchGrid',{'multipleSearch':true} );
 }
});

 Enjoy

Tony


Good point. I missed that. Thanks for the sharp eye Tony. It appears to be working now!

Thanks again! 

Jack

02/06/2011
17:24
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

Hi Tony,

I just noticed another bug with the search filter dialog box in single search mode. The top "AND OR" operator dropdown list appears if the user clicks on the refresh (Reload grid) button from the pager bar of the main grid.

Thanks

Jack

08/06/2011
15:39
Avatar
jhsu
Member
Members
Forum Posts: 23
Member Since:
05/11/2009
sp_UserOfflineSmall Offline

Hi Tony,

Is there anyway to make the search dialog modal again like v3.8 to work around the issue described above while it's being worked on?

To reiterate the issue:

When the search dialog comes up in single search mode, clicking on the reload grid button on the pager bar unhides the AND/OR operator select dropdown list.

Thanks Tony

Jack

08/06/2011
19:59
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

Hello jhsu,

I think you are right. The problem is that the hiding of the "Add-rule" and "Delete-rule" buttons will be done in grid.formedit.js (see the line 163)

if(p.multipleSearch === false) {
    $(".add-rule","#"+fid).hide();
    $(".delete-rule","#"+fid).hide();

and not in the grid.filter.js module. On the other side the new Filter module make refresh of all contain (the call of reDraw method) in many cases. For example one can just click on the Reset button of the searching dialog to make the buttons visible.

Tony, if you would makes modification of grid.filter.js module it would be nice if you make other small changes. For example, currently Filter dialog allows to remove the last filter Rule. It was not permitted in the old Advance Searching dialog (see the demo from the answer for example). Including of more public events like beforeRedraw and afterRedraw and so on would be very helpfull for the Filter dialog customization. Support of keyboard events (at least Esc and Enter) would be also very helpful. Currently the setting of closeOnEscape:true as the searching option will be just ignored. The option searchOnEnter would be great to have.

In the current implementation of grid.filter.js almost any customization of the Searching dialog can be implemented only with respect of overwriting of Filter methods (see here and here).

Best regards
Oleg

17/06/2011
12:41
Avatar
Ankit
New Member
Members
Forum Posts: 1
Member Since:
10/06/2011
sp_UserOfflineSmall Offline

jhsu said:

Hi Tony,

Is there anyway to make the search dialog modal again like v3.8 to work around the issue described above while it's being worked on?

To reiterate the issue:

When the search dialog comes up in single search mode, clicking on the reload grid button on the pager bar unhides the AND/OR operator select dropdown list.

Thanks Tony


Hi Tony,

Is there any fix regarding the above issue as I am also facing the same problem while reloading the grid the 'AND' & 'OR' drop down is visible again. Which is not supposed to be there in Simple Single search.

Eagerly waiting for the reply,

Thanks in advance,

Ankit

17/06/2011
13:25
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

You are right Ankit, the problem still exist in jqGrid 4.1.

One can reproduce the problem on the following demo:

1) one open search dialog which will looks correct.

2) one close the dialog

3) one clich "Reload Grid" button from the navigation bar

4) one open the search dialog one more time. One will see "Advance Searching" dialog instead of "Single Value Search" dialog:

Image Enlarger

Best regards
Oleg 

17/06/2011
14:38
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Oleg,

This work for me fine. No problems. FF4 and Chome on Ubuntu.

Should I think it is ony in IE?

Will check

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

17/06/2011
16:17
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

It's very strange! I can reproduce the problem in all web browsers which I have on my Windows 7 SP1 computer:

the last version of Google Chrome (12.0.742.100), Internet Explorer 9 (9.0.8112.16421), Safari 5.0.5 (7533.21.1), Opera 11.11 (build 2109), Firefox 3.6.17 and Nightly 7.0a1 (2011-06-16).

I used the same demo and followed the instructions which I described before: Open, Close single search dialog, clicked Reload Grid button on the navigation bar and then open the search dialog one more time. I see the Advance Search dialog instead of Single Search dialog.

Best regards
Oleg 

18/06/2011
11:21
Avatar
tony
Sofia, Bulgaria
Moderator
Members

Moderators
Forum Posts: 7721
Member Since:
30/10/2007
sp_UserOfflineSmall Offline

Oleg.

Always thank you. You are absolutley right. I misunderstud  the word reloading - I mean reloading browser, but not the grid.

Fixed. Also make it so that the buttons are created/not created in the filter, but not in the search dialog.

Thank again

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

18/06/2011
12:01
Avatar
OlegK
Germany
Member
Members
Forum Posts: 1255
Member Since:
10/08/2009
sp_UserOfflineSmall Offline

You are welcome!

The first look at the modified code seems be very good. Introducing of the ruleButtons should solve the problem.

What do you think about infroducing of the new events at least afterRedraw which will be called at the end of reDraw method. In the current implementation of the grid.filter.js it is very difficult to make any customizing of the dialog. In form editing one can use afterShowForm event for example to make any changes in the form. The grid.filter.js redraw/recreate the full contain on the searching dialog, so all changes from afterShowSearch will be destroyed. Introducing of more public events could solve the problem.

I use "public event" because filter module has onChange for example, but it is already used in the grid.formedit.js (see here).

I hope you understand the problems with the usage of the current version of the grid.filter.js. Such simple thing like setting of the focus on another field is really difficult to implement now. I used overwriting of reDraw method as a workaround (see here).

Best regards
Oleg 

This topic is locked No permission to create posts
Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
74 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

OlegK: 1255

markw65: 179

kobruleht: 144

phicarre: 132

YamilBracho: 124

Renso: 118

Member Stats:

Guest Posters: 447

Members: 11373

Moderators: 2

Admins: 1

Forum Stats:

Groups: 1

Forums: 8

Topics: 10592

Posts: 31289

Newest Members:

, razia, Prankie, psky, praveen neelam, greg.valainis@pa-tech.com

Moderators: tony: 7721, Rumen[Trirand]: 81

Administrators: admin: 66

Comments are closed.
Privacy Policy   Terms and Conditions   Contact Information