jQuery Grid Plugin - jqGrid - Topic: usage of jQuery.parseXML and other jQuery functions http://www.trirand.com/blog/?page_id=393/discussion/usage-of-jquery-parsexml-and-other-jquery-functions Simple:Press Version 5.7.5.3 tony on usage of jQuery.parseXML and other jQuery functions http://www.trirand.com/blog/?page_id=393/discussion/usage-of-jquery-parsexml-and-other-jquery-functions#p28358 Discussion http://www.trirand.com/blog/?page_id=393/discussion/usage-of-jquery-parsexml-and-other-jquery-functions#p28358 Hello Oleg,

You are absolutley right.

Will begin with this today.

Thanks.

Best Regards

Tony

]]> Fri, 01 Mar 2013 10:01:02 +0200 OlegK on usage of jQuery.parseXML and other jQuery functions http://www.trirand.com/blog/?page_id=393/discussion/usage-of-jquery-parsexml-and-other-jquery-functions#p28345 Discussion http://www.trirand.com/blog/?page_id=393/discussion/usage-of-jquery-parsexml-and-other-jquery-functions#p28345 Hello Tony,

I suggest to reduce a little the size of jqGrid by usage standard jQuery functions. For example one can use jQuery.parseXML (see the source code) is very close to the code of stringToDoc used by jqGrid. So it seems to me that one can replace the line of grid.base.js

dstr = $.jgrid.stringToDoc(ts.p.datastr);

to

dstr = typeof ts.p.datastr !== 'string' ? ts.p.datastr : $.parseXML(ts.p.datastr);

and another line of grid.import.js

var xmld = $.jgrid.stringToDoc(o.impstring);

to

var xmld = $.parseXML(o.impstring);

One can examine additionally the requirements of usage JsonXml.js (at least the most parts of the code) and the usage of $.jgrid.parse. It seems to me that one can remove all or some parts of the code and use standard methods which are now in jQuery.

Additionally it would be good to place directly on the jqGrid download page and in the documentation which versions (from, till) of jQuery are supported by which versions of jqGrid.

It seems to me that one can also remove now some from the functions declared and used in the jquery.fmatter.js module (for example $.fmatter.isNull which will be never used or $.fmatter.isUndefined). For exmaple $.fmatter.isUndefined will be used only inside of jquery.fmatter.js module. The line like this one 

if(opts.colModel !== undefined && !$.fmatter.isUndefined(opts.colModel.formatoptions)) {

can be safe replaced to

if(opts.colModel !== undefined && opts.colModel.formatoptions !== undefined) {

or

if(opts.colModel != null && opts.colModel.formatoptions != null) { // test for null or undefind

All the changes which I suggest here are not really important, but I think that it's good to clean up code from time to time.

Best regards
Oleg

]]> Thu, 28 Feb 2013 12:01:47 +0200