jQuery Grid Plugin - jqGrid - Topic: wrong calculation of the width of the grid if shrinkToFit is false http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false Simple:Press Version 5.7.5.3 OlegK on wrong calculation of the width of the grid if shrinkToFit is false http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21728 Bugs http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21728 Thank you Tony!

Now the code on GitHub contain all changes which I need. I will test the code inside of copy of real project which I developed about one year ago and where I should make a small update in the month. If I will find any problem I will post my results here as usual.

Best regards
Oleg 

]]> Mon, 17 Jan 2011 00:03:13 +0200 tony on wrong calculation of the width of the grid if shrinkToFit is false http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21709 Bugs http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21709 Oleg,

I think tha the real fix should be:

if (ts.p.shrinkToFit === false) {initwidth += brd*cl;}

This is true since before this condition we have

if (isSafari) { brd=0; }
$.each(ts.p.colModel, function(i) {
      if(typeof this.hidden === 'undefined') {this.hidden=false;}

…

Since brd = 0 when safari the first condition is not needed.

Also fixed in GitHub

As for the jqChart - Thank you very much for the recommendatoion.

Also we have additional to this 4 themes they are not shown in the demo.

Definitley we will develop such theme.

Tony

]]> Sun, 16 Jan 2011 15:54:48 +0200 OlegK on wrong calculation of the width of the grid if shrinkToFit is false http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21593 Bugs http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21593 Thanks for the information, Tony!

jqChart seems me very interesting. Only one small advice from me. Microsoft charts has many 3D effects. Your jqChart has on the other side very nice animation effects and good interaction. I would recommend you include some gradient effects in some your demos. Including CSS with gradient effects (see my old demo) in the "Column and Bar charts" for example makes almost no additional work, but the charts could look even more better.

Best wishes
Oleg

]]> Sun, 09 Jan 2011 21:45:58 +0200 tony on wrong calculation of the width of the grid if shrinkToFit is false http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21588 Bugs http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21588 Oleg,

Thank you for remaind us

Currently we are busy with the new version of jqSuite,

http://www.trirand.net/demochartphp.aspx

which will include charts and a ton of improvements in the php grid.

I see all the posts in this forum instead and next week I will really work on all of your recommendations and fixes.

Of course I will look in all other posts.

Thank you again for all your efforts

Best Regards

Tony

]]> Sun, 09 Jan 2011 14:23:14 +0200 OlegK on wrong calculation of the width of the grid if shrinkToFit is false http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21587 Bugs http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21587 Hello Tony!

Could you find time to look in my suggestion, so that the corresponding bug fix could be included in the next release of jqGrid. I posted demos which reproduce the problem and which demonstrate that after changing only one line of the jqGrid code the problem could be fixed.

Thank you
Oleg 

]]> Sat, 08 Jan 2011 19:24:28 +0200 OlegK on wrong calculation of the width of the grid if shrinkToFit is false http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21257 Bugs http://www.trirand.com/blog/?page_id=393/bugs/wrong-calculation-of-the-width-of-the-grid-if-shrinktofit-is-false#p21257 Hello Tony!

It seems I found one bug in the jqGrid calculation. If option shrinkToFit is set to false and width parameter is either not defined or defined as "100%" one a simple grid (see demo) one see horizontal scroll bars in all popular Web browsers excepting Google Chrome and Safari:

bug in FirefofImage Enlarger

If the same demo will be read from the local file in the Internet Explorer one sees also the vertical scroll bars:

bug in IEImage Enlarger

If one defines additional width parameter explicitly as

width: $.browser.safari ? 605 : 640

the problem will be fixed. So the calculation of the grid width should be changed to have the values specified above. To have possibly less changes in jqGrid, I suggest to fix the bug in the setColWidth function of the grid.base.js including additional line

if (!isSafari && ts.p.shrinkToFit === false) {initwidth += brd*cl;}

before the line 1827. The same demo used with the fixed version of jqGrid code can be seen here. I tested the suggestion in the last versions of Opera/IE8/IE9beta/Chrome/Firefox/Safari.

Best regards
Oleg 

]]> Sun, 12 Dec 2010 23:22:13 +0200