jQuery Grid Plugin - jqGrid - Topic: typing bug with max/min in addJSONData and addXmlData http://www.trirand.com/blog/?page_id=393/bugs/typing-bug-with-maxmin-in-addjsondata-and-addxmldata Simple:Press Version 5.7.5.3 OlegK on typing bug with max/min in addJSONData and addXmlData http://www.trirand.com/blog/?page_id=393/bugs/typing-bug-with-maxmin-in-addjsondata-and-addxmldata#p25480 Bugs http://www.trirand.com/blog/?page_id=393/bugs/typing-bug-with-maxmin-in-addjsondata-and-addxmldata#p25480 Congratulation!

It's good to publish releases with bug fixes.

Best regards
Oleg

]]> Tue, 20 Dec 2011 13:07:41 +0200 tony on typing bug with max/min in addJSONData and addXmlData http://www.trirand.com/blog/?page_id=393/bugs/typing-bug-with-maxmin-in-addjsondata-and-addxmldata#p25479 Bugs http://www.trirand.com/blog/?page_id=393/bugs/typing-bug-with-maxmin-in-addjsondata-and-addxmldata#p25479 Hello Oleg,

No need to say Sorry. I must say Thank you.

Just released the 4.3.1

Best Regards

Tony

]]> Tue, 20 Dec 2011 12:25:47 +0200 OlegK on typing bug with max/min in addJSONData and addXmlData http://www.trirand.com/blog/?page_id=393/bugs/typing-bug-with-maxmin-in-addjsondata-and-addxmldata#p25471 Bugs http://www.trirand.com/blog/?page_id=393/bugs/typing-bug-with-maxmin-in-addjsondata-and-addxmldata#p25471 Hello Tony,

in addJSONData and addXmlData there are typing bug (the lines 1212 and 1383):

ts.p.lastpage = Math.min( ts.p.page, Math.ceil(gl/ rn) );

or

ts.p.lastpage = Math.min( ts.p.page, Math.ceil(len/ rn) );

should be fixed to

ts.p.lastpage = Math.max( ts.p.page, Math.ceil(gl/ rn) );

or

ts.p.lastpage = Math.max( ts.p.page, Math.ceil(len/ rn) );

Probobly even better to go back to the original lines

ts.p.lastpage = Math.ceil(gl/rn);

and

ts.p.lastpage = Math.ceil(len/rn);

To reproduce the bug one can just fill the grid having loadonce: true option with many pages of data. If the page parameter of the JSON data are set for example to 1 (the first page schould be displayed), then the lastpage will be set to 1, corresponds to the above described bug, instead of Math.ceil(len/rn) which correspond to the number of read records.

It's bug from my old suggestion. After the line 1117 with

if (gl > 0 && ts.p.page <= 0) { ts.p.page = 1; }

and the line 1286 with

if (len > 0 && ts.p.page <= 0) { ts.p.page = 1; }

were included in the jqGrid code the real problem which should fix ts.p.lastpage = Math.max( ts.p.page, Math.ceil(gl/ rn) ); will be eliminiet. Sorry.

Best regards
Oleg 

]]> Mon, 19 Dec 2011 19:47:06 +0200