dajaney on Some Bugfixes for 3.6.5

Wed, 12 May 2010 15:47:18 +0300

Klaus, you are awesome 🙂

You don't just complain, you provide solutions. The perfect tester!

Klaus on Some Bugfixes for 3.6.5

Fri, 07 May 2010 11:37:25 +0300

here is another fix:

$.jgrid.extend({
getGridParam : function(pName) {
    var $t = this[0];
-     if (!$t.grid) {return;}
+     if (!$t || !$t.grid) {return;}    //FIX: avoid exception for empty jQuery sets
    if (!pName) { return $t.p; }
else {return typeof($t.p[pName]) != "undefined" ? $t.p[pName] : null;}
},

tony on Some Bugfixes for 3.6.5

Thu, 06 May 2010 13:39:59 +0300

HEllo,

Thanks Klaus, all of these have sense. Will be added.

Best Regards

Tony

Klaus on Some Bugfixes for 3.6.5

Wed, 05 May 2010 18:03:07 +0300

Hello Tony,

I've just updated to the latest jqGrid release 3.6.5.

Many of my previous bug fixes have already been applied and included – thank you

But the following fixes should improve stability by preventing access to unavailable fields – most times these problemes only occur with async tasks (esp. with IE)

@addXmlData:
ts.p.totaltime = new Date() – startReq;
if(ir>0 && ts.rows && ts.rows.length > 0) { ts.grid.cols = ts.rows[0].cells; if(ts.p.records===0) { ts.p.records=gl;} } // FIX: prevent access on undefined object (rare error case in IE)

@addJSONData:
ts.p.totaltime = new Date() – startReq;
if(ir>0 && ts.rows && ts.rows.length > 0) {ts.grid.cols = ts.rows[0].cells;if(ts.p.records===0)ts.p.records=len;} // FIX: prevent access on undefined object (rare error case in IE)

@setGridWidth:
return this.each(function(){
+   if (!this.grid) {return;}    // FIX: accessing $t.p… for non jqgrid elems
    var $t = this, cw,
    initwidth = 0, brd=$t.p.cellLayout, lvc, vc=0, hs=false, scw=$t.p.scrollOffset, aw, gw=0, tw=0,
    cl = 0,cr;
-   if (!$t.grid ) {return;}
    …

@getCellIndex:
getCellIndex : function (cell) {
-   cell = $(cell);
-   cell = (!cell.is('td') && !cell.is('th') ? cell.closest("td,th") : cell)[0];
-   if ($.browser.msie) { return $.inArray(cell, cell.parentNode.cells); }
-   return cell.cellIndex;
+   // FIX: avoid exception when given dom node is a tr
+   var c = $(cell);
+   if (c.is('tr')) { return -1; }
+   c = (!c.is('td') && !c.is('th') ? c.closest("td,th") : c)[0];
+   if ($.browser.msie) return $.inArray(c, c.parentNode.cells);
+   return c.cellIndex;
}

another improvement I applied in the jqGrid JS-files is for the document-body selectors:

replace $('body') -> with $(document.body) .. in all JS-files

Kind regards,
Klaus.

jQuery Grid Plugin - jqGrid - Topic: Some Bugfixes for 3.6.5

dajaney on Some Bugfixes for 3.6.5

Klaus on Some Bugfixes for 3.6.5

tony on Some Bugfixes for 3.6.5

Klaus on Some Bugfixes for 3.6.5