jQuery Grid Plugin - jqGrid - Topic: .scrollGrid() function breaks backward compatibility

tony on .scrollGrid() function breaks backward compatibility

Wed, 20 Apr 2011 12:30:23 +0300

Hello,

Added.

https://github.com/tonytomov/jqGrid/commit/c2b30cc091bd098eab32e6ed3b7debd6ff011e54

Regards

Tony

mnaoumov on .scrollGrid() function breaks backward compatibility

Tue, 19 Apr 2011 10:32:52 +0300

Dear Tony

First of all your code is not correct

Probably you meant

$('#grid').scroll( $('#grid').scrollGrid );

But actually it is not that we wanted to achieve.

We called scrollGrid() method because we wanted to enforce scrolling

To fix the issue mentioned above I wrote a simple workaround:

grid.scrollGrid($.Event());

but actually I don't like this ugliness and think that my suggestion from first topic should be done in jqGrid library

tony on .scrollGrid() function breaks backward compatibility

Tue, 19 Apr 2011 10:24:19 +0300

Hello,

The correct way is

$('#grid').scroll( scrollGrid );

The purpose of this function is not to be called as method, but as other code inside the grid (not outside)

Regards

Tony

mnaoumov on .scrollGrid() function breaks backward compatibility

Tue, 19 Apr 2011 10:10:19 +0300

Sorry for unclear topic 🙂

The use case is quite simple:

you just call

$('#grid').scrollGrid();

and this code will fail in jqGrid 4.0, because its parameter e is undefined.

It fails silently but if you attach debugger with prompting on errors you will see the error.

tony on .scrollGrid() function breaks backward compatibility

Tue, 19 Apr 2011 10:05:21 +0300

Hello,

In which cases this brake the code? In which browser? In which jQuery version? and etc.

A testcase will be great appreciated.

I think there is something else here ( maybe your own custom code for scrolling)

Actually I do not have such problems.

Regards

Tony

mnaoumov on .scrollGrid() function breaks backward compatibility

Tue, 19 Apr 2011 07:07:40 +0300

scrollGrid() function breaks backward compatibility

In previous versions (3.8.2) scrollGrid function has signature

scrollGrid: function() { … }

In version 4.0.0

scrollGrid: function(e) { … e.stopPropagation(); }

So such code from 3.8.2: grid.scrollGrid() fails with error

Message: 'undefined' is null or not an object

Line: 832

Char: 5

Code: 0

URI: http://localhost/Project/JavaS.....rid.src.js

I think that last lines in scrollGrid() should be replaced with

if (e) e.stopPropagation();