jQuery Grid Plugin - jqGrid - Topic: populate array using addRowData with array

OlegK on populate array using addRowData with array

Sat, 12 Jan 2013 12:20:30 +0200

You are right Tony! One should test only for undefined value.

tony on populate array using addRowData with array

Sat, 12 Jan 2013 10:36:40 +0200

Hello,

Thank you for the bug fix.

Oleg I do not think that your fix is fine.

Suppose the rowid becomes 0 (data[cnm]=0), then the logic will go to randid which is not correct.

I think that the fix from GeorgeG is ok and I will implent this fix.

Thanks again

Tony

OlegK on populate array using addRowData with array

Fri, 11 Jan 2013 13:43:39 +0200

I think that the line

try {rowid = data[cnm];}

can be fixed to

try {rowid = data[cnm] || $.jgrid.randId();}

which is equivalent to (short form)

try {rowid = data[cnm] ? data[cnm] : $.jgrid.randId();}

Best regards
Oleg

P.S. I suppose that Tony will make the corresponding changes in the code of jqGrid after reading of your bug report.

GeorgeG on populate array using addRowData with array

Fri, 11 Jan 2013 04:54:25 +0200

Hello All,

I think I have found a bug in addRowData (grid.base.js), when using jqGrid with a local array.

If the rowid is not supplied, or does not exist in the source array, there is an attempt to fallback to the internal id generation mechanism, as follows (lines 2961-2962):

try {rowid = data[cnm];}
catch (e) {rowid = $.jgrid.randId();}

when data[cnm] does not exist Javascript (at least with the latest version of Chrome, Firefox IExplorer and a Web Browser (debian) 2.30.6) will not throw an exception for the assignment, so there is nothing to "catch".

The effect on the browser, is that the id of all the rows will be undefined. As such when the user clicks any row, the first row is selected (as the string "undefined" is assigned to all the rowids). The ids get populated properly if the rows are sorted (via a sortable column).

My temporary fix was to replace the two lines above with the following:

try { rowid = data[cnm];
    if(rowid ===undefined) {
        rowid = $.jgrid.randId();
    }
} catch (e) {rowid = $.jgrid.randId();}

I don't think that the "fix" above breaks anything.

p.s.: Don't ask me why I used jqGrid with an array and an undefined id column…

Regards,

GeorgeG

Edited to correct late night/early morning typing errors 🙂