tony on [PATCH] custom edit doesn't work for anything but "input" element

Tue, 08 Jun 2010 15:03:22 +0300

Hello,

Thanks. Fixed.

Best Regards

Tony

vchekan on [PATCH] custom edit doesn't work for anything but "input" element

Mon, 07 Jun 2010 21:57:55 +0300

I'm using form's plugin custom edit feature:

editoptions: {
                        custom_element: sitesGridCreate,
                        custom_value: sitesGridValue
                    }},

and it does not call custom_vale function which I defined (sitesGridValue).

Debugging showed that problem is in grid.formedit.js:getFormData:

                        var elem = celm[0], nm = elem.name;
                       $.each($t.p.colModel, function(i,n){
                           if(this.name == nm && this.editoptions &&     $.isFunction(this.editoptions.custom_value)) {

The "name" attribute is set when custom element is created:

grid.formedit.js grid.common.js:createEl:

celm = jQuery(celm).addClass("customelement").attr({id:options.id,name:options.name});

Pay attention that "attr" was called on jQuery object, not on DOM object. But in formedit plugin's code above "name" is accessed as DOM property. It works for things like "input", which have "name" property in DOM, but if I create more complex custom element which is wrapped in "div", its DOM name property is "undefined".

The fix is as easy as:

var elem = celm[0], nm = $(elem).attr('name');

jQuery Grid Plugin - jqGrid - Topic: [PATCH] custom edit doesn't work for anything but "input" element

tony on [PATCH] custom edit doesn't work for anything but "input" element

vchekan on [PATCH] custom edit doesn't work for anything but "input" element