tony on one need use deep (recursive) jQuery.extend in grid.formedit.js

Thu, 22 Nov 2012 12:10:05 +0200

Thanks Oleg,

I have made a pull request.

Regards

Tony

OlegK on one need use deep (recursive) jQuery.extend in grid.formedit.js

Wed, 21 Nov 2012 13:41:45 +0200

Hallo Tony,

during answering of one question on the stackoverflow I found bugs in grid.formedit.js module. The method editGridRow for example use in the lines the call of jQuery.extend without the usage of deep (recursive) version. So the current code uses

p = $.extend({...}, $.jgrid.edit, p || {});

So all options which are objects (ajaxEditOptions, editData, savekey, navkeys, ...) can be extended incorrectly especially if some settings of the options are set in both $.jgrid.edit and input parameters of editGridRow. In the case the options will be not combined as expected. To fix the problem one can use

p = $.extend(true, {...}, $.jgrid.edit, p || {});

It seems to me that one should use deep form of jQuery.extend everywhere in the code of jqGrid.

Best regards
Oleg

jQuery Grid Plugin - jqGrid - Topic: one need use deep (recursive) jQuery.extend in grid.formedit.js

tony on one need use deep (recursive) jQuery.extend in grid.formedit.js

OlegK on one need use deep (recursive) jQuery.extend in grid.formedit.js