jQuery Grid Plugin - jqGrid - Topic: InlineVan bug reproducable just with demo site and firebug

tony on InlineVan bug reproducable just with demo site and firebug

Thu, 05 Apr 2012 13:14:48 +0300

Hello,

First of all - thank you.

If I remember I think this is fixed. I will check it again.

Regards

Tony

saul_page on InlineVan bug reproducable just with demo site and firebug

Mon, 02 Apr 2012 23:30:35 +0300

Sorry typo should have read InlineNav...

I'm not very good following javascript but I believe the issue is in the way the add new record code reuses the edit code to do the bulk of the work. The add code seems to use the extraparams feature to set the oper to add. Then calls the edit functionality. Theres some data overriding which overrides the edit oper with add. This extra param seems to hang around and nevers gets reset so when the edit code gets called normally again the override is still in place.

I'm not 100% sure where the code should be fixed for now I've just changed the following which seems to be working OK:

Line 9212:

oper = opers.oper;

o.editParams.extraparam = {};

}

o.editParams.extraparam[oper] = opers.addoper;

}

($("#"+$.jgrid.jqID(sr), "#"+$.jgrid.jqID($t.p.id) ).hasClass("jqgrid-new-row")) {var opers = $t.p.prmNames,if(!o.editParams.extraparam) {

else

{

// new code here

o.editParams.extraparam = {};

}

I'm not suggesting this as a fix because it will probably break actual valid use of the extra param feature but I'm not using that feature so it works for me. Hopefully a proper fix can be easily added to the next version.

saul_page on InlineVan bug reproducable just with demo site and firebug

Thu, 29 Mar 2012 11:55:48 +0300

Hi, first thanks for a great grid. I have found a potentially critical bug when using the InlineNav editing feature.

The problem I'm seeing is that once you add a new record using the inline editing feature from the nav grid the "oper" parameter in the POST data is always set to "add" even after the record has been added and subsequently then "edit" different records. Its like it gets permanently set to "add"

I can see this behaviour using the inline nav editing demo and looking at the Post data in Firebug.

Reproduction case:

Navigate to:

http://www.trirand.com/blog/jq.....  ( then select Row Editing (new) from NAV list, then InLineNavigator (new).

Open up firebug and monitor the POST data.

Add a new row and save - "oper" is "add" (correct)

Edit a different row and save - "oper" is "add" (incorrect should be "edit")

It also doesn't help if I reload the grid midway.

It would be great if to confirm wether this is a bug or if I've misunderstood something.