jQuery Grid Plugin - jqGrid - Topic: formedit default text field length - grid.common.js

akremedy on formedit default text field length - grid.common.js

Thu, 16 Apr 2009 12:21:06 +0300

Cool, thanks Tony!

tony on formedit default text field length - grid.common.js

Thu, 16 Apr 2009 02:08:16 +0300

Hello Keith,

Done in 3.5 alfa 3 (the width of the select)

Regards

Tony

Keith Ivey on formedit default text field length - grid.common.js

Tue, 14 Apr 2009 11:02:03 +0300

That's fine for text, password, and textarea because you can avoid it by setting size or cols. But for select there needs to be a way to avoid setting the width to 98% or 99% or whatever is decided. I'd prefer not having that happen at all, just leave them at the width the browser gives them (based on the width of the options), and let people set it to 99% in the stylesheet if that's what they want.

akremedy on formedit default text field length - grid.common.js

Tue, 14 Apr 2009 03:42:47 +0300

Thanks Tony, that actually makes even more sense - and simpler too.

Adam

tony on formedit default text field length - grid.common.js

Tue, 14 Apr 2009 01:03:32 +0300

Hello,

Thanks - IMHO the condition should be changed to:

if(!options.size) {

for password, and text

and

options.cols is for textarea.

the parameter elm in createEl is not needed.

The % should be equall to all. Thanks

Regards

Tony

akremedy on formedit default text field length - grid.common.js

Mon, 13 Apr 2009 21:59:40 +0300

Hi Tony, I think there's a little defect in grid.common.js. If you don't include the colModel parameter "editoptions:{size:#}", text fields should default to 98%, password to 99%.

In grid.common.js, in createEl, in case "textarea", case "text" and case "password", it looks for:

if(!options.size && elm) {

It appears that this should be:

if(!options.size && elem) {

I tested this change, and it seems honor the % width only with the modified variable in place.

This happens to be the 3.5A2 release, but it looks like it may go back to at least 3.3.2.

Thanks,

Adam