jQuery Grid Plugin - jqGrid - Topic: duplicate rowid produced by addRow

OlegK on duplicate rowid produced by addRow

Thu, 08 Nov 2012 13:26:49 +0200

Sorry, my last suggestion was based on my *original* code where the value of rowID was undefined. One uses $.extend with input parameters. So one can't ovewrite any other value with the undefined value. If you use null as the default value then rowID will never been undefined, but it's not a real problem. So your previous suggestion will work exacly so good as the last one. Sorry for the misunderstanding.

Regards
Oleg

tony on duplicate rowid produced by addRow

Thu, 08 Nov 2012 11:59:08 +0200

Oleg,

Ok. Changed, but I think nobody will set a undefined.

Regards

OlegK on duplicate rowid produced by addRow

Thu, 08 Nov 2012 11:38:59 +0200

Yes, of cause! But I think that it's better to use (p.rowID != null) instead of (p.rowID !== null) to test for not null or not undefined instead of testing for null only.

Regards

tony on duplicate rowid produced by addRow

Thu, 08 Nov 2012 11:29:13 +0200

Thanks Oleg.

Published in GitHub. You maybe mean :

(p.rowID !== null) ? p.rowID : $.jgrid.randId()

Best Regards

OlegK on duplicate rowid produced by addRow

Thu, 08 Nov 2012 11:15:27 +0200

Hello Tony,

you are right. It's better to use

(p.rowID == null) ? p.rowID : $.jgrid.randId()

(test for null or undefined) instead of

p.rowID ? p.rowID : $.jgrid.randId()

Regards
Oleg

tony on duplicate rowid produced by addRow

Thu, 08 Nov 2012 10:49:14 +0200

Hello Oleg,

Thanks. This is ok.

The only thing for me is that the rowID should be set from undefined to null and we should perform check if

we want to add a row with id = 0, then this p.rowID ? p.rowID : $.jgrid.randId()

will produce bad call of randID.

Regards

OlegK on duplicate rowid produced by addRow

Wed, 07 Nov 2012 14:39:18 +0200

Hello Tony,

default parameter of addRow contains rowID: "new_row". As the result the simplest usage of inlineNav with local grid (having editurl: "clientArray") will produce id duplicates if one add multiple rows to the grid with respect of clicking on the "Add" button.

Additional problem is that one can't use function as the value of rowID. So one can't produce unique ids or just different ids in a simple way.

I suggest to fix the code of in the following way (I marked changed places with bold font):

addRow : function ( p ) {
p = $.extend(true, {
rowID : undefined,
initdata : {},
position :"first",
useDefValues : true,
useFormatter : false,
addRowParams : {extraparam:{}}
},p || {});
return this.each(function(){
var $t = this,
rowID = $.isFunction(p.rowID) ? p.rowID.call($t, p) : (p.rowID ? p.rowID : $.jgrid.randId());
...
... in the code below the usage of p.rowID will be replaced to
... the usage of new rowID variable.
...
});
},

I changed the default value of rowID to undefined to force call of in case of the simplest usage of addRow method. Additionally the line

addParams : {useFormatter : false,rowID : "new_row"},

of inlineNav which defines default values of inlineNav should be changed to

addParams : {},

Best regards
Oleg