jQuery Grid Plugin - jqGrid - Topic: Date having wrong parsed with srcformat: "ISO8601Long"

OlegK on Date having wrong parsed with srcformat: "ISO8601Long"

Wed, 05 Feb 2014 17:34:48 +0200

It's very good news about new version!

After publishing of the version I would like to post you some pull requests with my suggestions how all icons and texts used in jqGrid can be configured more flexibly. The goal is providing of simple way to choose Font Awesome icons or other vector based icons instead of standard jQuery UI icons. The current code contains the most icons directly in the code and it inserts "ui-icon" class additionally. I think that the code can use the function like $.jgrid.icons.getClass("iconName") or everywhere in the code (for example $.jgrid.icons.getClass("sortAsc"), $.jgrid.icons.getClass("pagerFirst") or $.jgrid.icons.getClass("navRefresh")). The value of this of $.jgrid.icons.getClass could be set to DOM of the grid, so that it can use current options of the current grid. In the same way one can easy create one grid with jQuery UI icons and another one with Font Awesome icons. In the same way the method $.jgrid.icons.getText could be used everywhere to get information from language specific files like grid.locale-en.js. The implementation of $.jgrid.icons.getText could read the information from static objects which structure could be close to the current language specific files grid.locale-XX.js. Usage of function would provide maximal flexibility and allows to place grids on the page with different language per grid.

Such kind of changes need be good tested. So I don't think that it would be reasonable to post the changes before new release of jqGrid.

Best regards
Oleg

tony on Date having wrong parsed with srcformat: "ISO8601Long"

Wed, 05 Feb 2014 16:25:42 +0200

Hello Oleg,

Many Thanks. Will fix the lang files.

We will publish the new release soon. I just prepare the docs for the new features.

Best Regards

Tony

OlegK on Date having wrong parsed with srcformat: "ISO8601Long"

Wed, 05 Feb 2014 12:46:16 +0200

Hello Tony,

you fixed removing 'T' character inside of parseDate and replaced it to #. Additionally you included lines

// old lang files
if(opts.parseRe === undefined ) {
opts.parseRe = /[#%\\\\\\/:_;.,\\t\\s-]/;
}

The problem is that language files like grid.locale-en.js for example have already parseRe defined with T (/[Tt%\\\\\\/:_;.,\\t\\s-]/) instead of # as (see here). So the paring of ISO dates are inclorrect. It's correct only in case of usage old language files (from version 4.5.0 or before).

To fix the problem one should either remove common line with definition of parseRe from all language files or fix the value.

Best regards
Oleg

P.S. Do you plan to publish new version of jqGrid next time?