jQuery Grid Plugin - jqGrid - Topic: DataUrl: ajax should use "success", not "complete"

vchekan on DataUrl: ajax should use "success", not "complete"

Thu, 17 Jun 2010 20:26:24 +0300

Well, I don't know. My guess is that most of existing code is broken, because I doubt people check that completion status is 'success'.

So may be it is possible to add a backward compatibility bit and retire old behaviour in a grace fashion?

Another option would be to introdcue another callback, let's say "dataUrlReady" which would be called properly. With clear documentation it would allow new code to do right things without breaking backward compatibility.

tony on DataUrl: ajax should use "success", not "complete"

Wed, 16 Jun 2010 13:08:59 +0300

Hello,

Maybe you are right, but changing right now complete with succes will cause all existing users to change a lot of code and expect a lot of problems.

Best Regards

Tony

vchekan on DataUrl: ajax should use "success", not "complete"

Tue, 15 Jun 2010 02:24:30 +0300

http://github.com/tonytomov/jq.....on.js#L321

if(typeof(options.dataUrl) != "undefined") {

...

complete: function(data,status){

  if(typeof(options.buildSelect) != "undefined") {
    var b = options.buildSelect(data);

I have strong impression that "complete" property was used by mistake.

First, of all, you perhaps do not want to feed error-ended call into buildSelect()

Second, "data" is XMLHttpRequest in fact. If you change "complete" to "success", then 1st argument will be "data" as intended.