tony on custom_element and custom_value bug with boolean values

Wed, 15 Jun 2011 12:10:50 +0300

Hello,

Thanks will be fixed today and some other minor bugs too.

We plan to publish 4.1.1 at end of this week.

Regards

Tony

keithd on custom_element and custom_value bug with boolean values

Wed, 15 Jun 2011 12:01:30 +0300

Hi. I'm making use of the custom_element and custom_value facility within the editoptions to create a radio button column. Data values are true, false and null and I expected the custom_element and custom_value functions to be able to convert these values into useful html content and back again.

This works as expected for the 'Yes' option but not for the 'No' option. A little digging about and I discovered this in the saveCell function:

// The common approach is if nothing changed do not do anything
if (v2 != $t.p.savedRow[fr].v)

v2 (false) and $t.p.savedRow[fr].v (empty string) aren't equal but the != coerces the values. The != should be replaced with !== which won't coerce the value types.

A similar bug is also present in the $.unformat function: when using a custom function, the value is stored in a variable called ret

ret = unformatFunc($(cellval).text(), options, cellval);

the return statement then checks the value of ret and if it is false (which should be a perfectly valid return value), substitutes it with the cells html contents.

return ret ? ret : cnt===true ? $(cellval).text() : $.jgrid.htmlDecode($(cellval).html());

Any plans to address these issues?

jQuery Grid Plugin - jqGrid - Topic: custom_element and custom_value bug with boolean values

tony on custom_element and custom_value bug with boolean values

keithd on custom_element and custom_value bug with boolean values