As long as everything else works OK, the programmer can always "tweak" the values of the cells to get the grid to behave the way they want.

Thanks for fixing it so quickly!

- Joe

Thanks for the opinion.

Especially for the count I do not agree. Suppose we want to count string, then it is very natural to count all one.

I Have fixed this in git hub.

Regards

Actually, after I posted my solution, I realized I wrote a custom formatter for percentages that was inserting the single space. Can't remember why exactly as it seemed to perform the same way when I took the single space out. Maybe it was a typo on my part.

I would think that if the cell value is null or, when the white space is trimmed, equals empty string, then the cell's value should not count towards the average.

At the very least, I think that null and empty string should not count - I think you could make a case either way about the trimming of whitespace.

Thanks!

- Joe

Thank you very much. Yes, I confirm this is a bug in getCol method.

We do not consider in avg the first row which should be excluded.

About the case if the cell value is " " I think that in this case we should interpret it as 0.

What do you think about this?

Regards

Tony

NOTE: I did NOT thoroughly test this yet but it solved the problems I was encountering.

                    var ln = $t.rows.length, i = 0, den = 0;
                    if (ln && ln > 0)
                    {
                        while (i < ln)
                        {
                            if ($($t.rows[i]).hasClass('jqgrow'))
                            {
                                try
                                {
                                    val = $.unformat.call($t, $($t.rows[i].cells[pos]), { rowId: $t.rows[i].id, colModel: $t.p.colModel[pos] }, pos);
                                } catch (e)
                                {
                                    val = $.jgrid.htmlDecode($t.rows[i].cells[pos].innerHTML);
                                }
                                if (mathopr)
                                {
                                    v = parseFloat(val);
                                    if (!isNaN(v))
                                    {
                                        sum += v;
                                        if (max === undefined) { max = min = v; }
                                        min = Math.min(min, v);
                                        max = Math.max(max, v);
                                        den++;
                                    }
                                }
                                else if (obj) { ret.push({ id: $t.rows[i].id, value: val }); }
                                else { ret.push(val); }
                            }
                            i++;
                        }
                        if (mathopr)
                        {
                            switch (mathopr.toLowerCase())
                            {
                                case 'sum': ret = sum; break;
                                case 'avg': ret = sum / den; break;
                                case 'count': ret = ln; break;
                                case 'min': ret = min; break;
                                case 'max': ret = max; break;
                            }
                        }
                    }