jQuery Grid Plugin - jqGrid - Topic: Breaking change in DateFormat for non-string value http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value Simple:Press Version 5.7.5.3 bakesteve on Breaking change in DateFormat for non-string value http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21865 Bugs http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21865 as a suggestion - perhaps should also allow formatter to fail gracefully?

so in jquery.fmatter line 58:

try {

v = $.fn.fmatter[formatType](cellval, opts, rwd, act); }

catch(ex) { 

if(opts.throwFormatExceptions==true) { throw ex; }

else {

return v;

//just return the original value

}

}

Would also need to add throwFormatExceptions to opts if want to allow fine grained control.

]]> Fri, 28 Jan 2011 14:51:35 +0200 tony on Breaking change in DateFormat for non-string value http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21405 Bugs http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21405 Thank you,

Will be fixed.

Tony

]]> Thu, 23 Dec 2010 20:18:37 +0200 OlegK on Breaking change in DateFormat for non-string value http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21404 Bugs http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21404 Thanks! Of course typeof date must be used instead of typedef date.

]]> Thu, 23 Dec 2010 16:16:55 +0200 ksherratt on Breaking change in DateFormat for non-string value http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21403 Bugs http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21403

OlegK said:

msMatch = ((typedef date === 'string') ? date.match(msDateRegExp): null),

Would the change solve your problem?

s/typedef/typeof/

Yep, that's essentially what I did.

]]> Thu, 23 Dec 2010 15:55:19 +0200 OlegK on Breaking change in DateFormat for non-string value http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21402 Bugs http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21402 Hello ksherratt,

Probably one can fix the bug by changing the line 120 of the jquery.fmatter.js from

msMatch = date.match(msDateRegExp),

to the following

msMatch = ((typedef date === 'string') ? date.match(msDateRegExp): null),

Would the change solve your problem?

Best regards
Oleg

]]> Thu, 23 Dec 2010 15:19:12 +0200 ksherratt on Breaking change in DateFormat for non-string value http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21400 Bugs http://www.trirand.com/blog/?page_id=393/bugs/breaking-change-in-dateformat-for-non-string-value#p21400 There appears to be a breaking change in the 3.8.2 version of DateFormat function (ln. 128 of jquery.fmatter.js) where the regex tests for a Microsoft format string.  If the object passed as the 'date' parameter is, in fact, a date value the 'match' method is undefined and thus an exception is thrown.

msMatch = date.match(msDateRegExp)

presumably should be qualified for either a string or method existence.  Have patched locally until 3.8.3 is released :)

]]> Thu, 23 Dec 2010 13:33:44 +0200